Skip to content

Conversation

@nsrahmad
Copy link
Contributor

React 18 to React 19

The React version was held back because of fluentui/react-icons dependency, which didn't support React 19. The version 1.1.311 of react-icons (released yesterday) finally adds support for React 19.

Docusaurus 3.9

This required few changes:

  1. Minimum required node version is now v20. But when I checked CI script, we already build it with node v20, so nothing else needs to be done, Except, updating the readme.
  2. In siteConfig, the option onBrokenMarkdownLinks is deprecated now (Removed in next major version), Replaced with siteConfig.markdown.hooks.onBrokenMarkdownLinks.
  3. If using translations (we do), Then if two items have same sidebar labels, they need to have a different key attribute (introduced in v3.9). This actually affected our build, as we had a case where this was true.

Typescript v5.8.3 -> v5.9.2

Didn't have any issues, so why not.

This finally brings every dependency to its latest official version.

This was held back by a dependency 'fluentui/react-icons', which didn't support React 19 until version 2.0.311 (released yesterday).
Also updates the minimum required node version from 18 to 20 (required by v3.9.1).
with the new option `markdown.hooks.onBrokenMarkdownLinks`.
…same label

Required by v3.9.1, otherwise the build fails.
@luke-whos-here luke-whos-here merged commit 65520df into AvaloniaUI:main Oct 20, 2025
2 checks passed
@luke-whos-here
Copy link
Contributor

Hi @nsrahmad, I merged your PR earlier today. Unfortunately, we had an error with the build. It looked like there were duplicated labels named 'Advanced' in the Accelerate and XPF sidebars, which caused the translated sites to fail.

I tried adding a differentiating key to the two instances of Advanced, but Docusaurus didn't seem to like that. I've reverted the merge for now while I continue investigating.

@nsrahmad nsrahmad deleted the upgrade-deps branch October 20, 2025 16:21
@nsrahmad
Copy link
Contributor Author

Hello @luke-whos-here, The PR was time sensitive. It built fine when I actually opened the PR, and should have been merged before adding further new content. The problemetic contents are added after the PR.
Anyway, I looked at the error and its soltion is same as described here 93a1f8e , I won't be able to help any further on this, Good luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants